cm: launcher: rank scheduling errors in balancer - #571
Conversation
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
65bc537 to
ea56756
Compare
mykola-kobets-epam
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature_release_9.1 #571 +/- ##
=======================================================
- Coverage 85.04% 85.03% -0.02%
=======================================================
Files 314 315 +1
Lines 28521 28544 +23
Branches 3823 3825 +2
=======================================================
+ Hits 24257 24272 +15
- Misses 4264 4272 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| } | ||
|
|
||
| Error scheduleErr = ErrorEnum::eNotFound; | ||
| RankedError scheduleErr; |
There was a problem hiding this comment.
Still do not understand why we need ranked error. Instance scheduling should fail on first error.
In our case, if there are different manifests for different arch. First we should check if there are nodes matches item arches. If not, return error - no suitable node architecture found. Then we try to schedule according to resource, if there are not enough resources available, return resource error.
2 participants
No description provided.